On an up-to-date OS X computer with FileVault 2 (whole-disk encryption, minus the recovery partition), is any security gained by setting a firmware password, as well?
The firmware password adds very little value to the protection of your device. There have already been published loopholes for either:
On several versions of the Mac OS. The FileVault encryption will be sufficient for protecting your information.