0

I create desktop client for one e-shop and this client will use some functions using e-shop's API, like:

GetOrders
UpdateOrder
SetOrder
etc...

I'm creating custom authentication for that client, but I don't know is it is secure against attacks.

All communication with client-server is done via HTTPS.

It works like this:

  1. At the first request client have to provide username and password to server. So client will hash that password what user inputs and then client will send request to server with username and hashed password.

  2. Server compares hashed password with hashed password in DB for that username, if it equal then server generates token (like api key) with limited life time and this token will send back to client.

  3. Client will use this token in future requests.

  4. At every successful token request server will renew token lifetime.

Requests should look like this:

POST /orders/get HTTP/1.1
Host: example.com
token=123456789&orderid=10

Is there any security recommendation if I should use POST requests or GET requests? Isn't POST more secure then GET? For example POST stores data in body of the HTTP request, but GET it stores in URL.

  • 1
    The use of a token is the established technique of session cookie. But your authentication looks wrong: possible duplicate of https security - should password be hashed server-side or client-side?. And as for POST vs GET see Is there a difference between GET and POST for web application security?. – Steffen Ullrich Sep 2 '18 at 12:15
  • @SteffenUllrich So how can I make authentication stronger? As I read it makes no sense to hash or send raw password. – tomsk Sep 2 '18 at 12:21
  • In order to make the authentication stronger you need to find out what the weakness of the current way is. The weakness of your current idea is that the server needs to store a password-equivalent. This weakness is gone if you do server-side hashing instead. This is a problem is the transport of the plain password is not protected but you've addressed this with HTTPS already. But of course, a password by itself can be a weakness, since it is often badly chosen. Client certificates provide a better security but might be a hassle to use. So, find out what security you actually need. – Steffen Ullrich Sep 2 '18 at 12:53
  • @SteffenUllrich So I understand, so it is strong if I use server side hashing right? So this communication is secure as far as someone doesn't broke SSL certificate right? I wonder how strong HTTPS really is. And what about man in middle attack? – tomsk Sep 2 '18 at 13:26
  • "I wonder how strong HTTPS really is. And what about man in middle attack?"- MITM is only possible if HTTPS is not strong enough, either by design or by the actual implementation. Design of TLS (the encryption layer of HTTPS) is seen as solid and that's why it is widely used. One can of course mess up the actual implementation or configuration, for example by not properly validating certificates or by trusting CA one should better not trust. But at the end one can probably mess up even the best design by not understand what one is doing. – Steffen Ullrich Sep 2 '18 at 14:17
1

Generally it depends what you want to do with the data. There are many differences between POST and GET. If you want to transmit data to your Server i prefer POST. It´s a bit more secure then GET because it doesn´t send the information with the URL and no data is stored. If you are using a shared PC it is possible that another user is looking if URL´s are stored. Maybe one guy submited his password or other details, they will be stored on the PC and another one can find it in the history.

Get is nice to use if you want to display a message to the User. As an example: One guy tries to log in, but he missspelled his Name, so access is not granted. The webserver can now answer that way -> serverurl.com/login?error=1

If error is set to one you can display the errormessage. Below you can find more differences between POST and GET. Main difference between POST and GET

Not the answer you're looking for? Browse other questions tagged or ask your own question.