I’m arguing with a colleague about the security of storing encrypted password on GitHub.
Our process is currently to commit a configuration file with environment variables including username and passwords. Username and passwords are opaque information in the file. They are then read by third party server who has the key to read it.
First of all, since the server is able to decrypt the password, it’s clear how this discussion might be irrelevant if we don’t trust the security of the server.
I would like to focus only on the particular file, assuming that the server is impenetrable.
My opinion is that the file should be commented to identify the various passwords and what their purpose is. Also I would leave usernames in clear text. This will make it slightly easier to maintain the file and update the relevant field if necessary. Without these pointers the configuration file looks like a wall of identical lines, each with opaque informations.
My colleague argues that this might give a hint to a hypothetical attacker.
Let’s leave aside the fact that if an attacker has access to our private repositories those passwords are the least of our problems.
Do you think that commenting the file gives away too much information or that it might make it easier to have a security hole?